update forms to better consistency with html5 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meanderfox
commented
Feb 3, 2024
| @@ -71,7 +71,6 @@ <h3><a name="level"></a>Select your registration options and level.</h3> | |||
| <hr/> | |||
| <div class="container-fluid"> | |||
| <div class="row" id="levelContainer"> | |||
| <noscript>Javascript is required for this site.</noscript> | |||
There was a problem hiding this comment.
this was on the page twice
rechner
reviewed
Feb 15, 2024
| @@ -49,13 +49,13 @@ <h1>Pre-Register for {{ event }}!</h1> | |||
|
|
|||
| {% show_attendee_form event=event emailOptions=True %} | |||
|
|
|||
| <h3><a name="level"></a>Select your registration options and level.</h3> | |||
There was a problem hiding this comment.
This anchor might be in place for jumping to from another part of the form
rechner
reviewed
Feb 15, 2024
| </div> | ||
|
|
||
| <div class="col-sm-5"> | ||
| <select id="bmonth" name="bmonth" class="form-control" required> | ||
| <select autocomplete="bday-month" class="form-control" id="bmonth" name="bmonth" required> |
There was a problem hiding this comment.
Personally, I don't like to alphabetize properties like this. The previous ordering places the properties most pertinent to DOM manipulation first, making it a little easier to read at a glance.
rechner
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.